Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaKernel] Add tests on PluginManager #240

Merged
merged 2 commits into from
Apr 25, 2017
Merged

[SofaKernel] Add tests on PluginManager #240

merged 2 commits into from
Apr 25, 2017

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Apr 7, 2017 •
edited by matthieu-nesme
Loading

Title says all :)

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings nor unit test failures.
  • does not break existing scenes.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).
  • has been reviewed and agreed to be transitional.
  • reports important changes in Changelog.

Reviewers will merge only if all these checks are true.

@fredroy
Copy link
Contributor Author

fredroy commented Apr 10, 2017

[ci-build]

@guparan guparan added the pr: status ready Approved a pull-request, ready to be squashed label Apr 19, 2017
matthieu-nesme
matthieu-nesme reviewed Apr 21, 2017
View reviewed changes
SofaKernel/framework/framework_test/CMakeLists.txt
@@ -31,6 +32,10 @@ if(SOFA_HAVE_PNG)
list(APPEND SOURCE_FILES helper/io/ImagePNG_test.cpp)
endif()

#Plugin tests
#add_subdirectory(plugin-system) ## TODO: check if deprecated or... ?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it the right time to clean that? :p

@damienmarchal
Copy link
Contributor

[ci-build]

@damienmarchal damienmarchal merged commit 8f2ab3f into sofa-framework:master Apr 25, 2017
@guparan guparan added this to the v17.06 milestone Jun 29, 2017
@fredroy fredroy deleted the pluginmanager_test branch September 14, 2017 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthieu-nesme matthieu-nesme matthieu-nesme left review comments

Assignees

@hugtalbot hugtalbot

Labels
pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v17.06
Development

Successfully merging this pull request may close these issues.
5 participants
@fredroy @damienmarchal @matthieu-nesme @guparan @hugtalbot